188.8.131.52. Code Submission Process¶
- Commits need to be logically separated. Don't fix unrelated things in one commit.
- Don't add unnecessary commits, if commit 2 fixes commit 1 merge them together (squash)
- Commits need to have proper messages, explaining anything that is non-trivial
- Commits should not at the same time change, rename and/or move code. Use separate commits for each of this, e.g, a commit to rename files, then a commit to change the code.
- Documentation updates should be in their own commit (not mixed with code commits)
- Commit messages need to be properly formatted:
- Meaningful and short (50 chars max) subject line followed by an empty line
- Naming convention: prefix message with sub-system ("rule parsing: fixing foobar"). If you're not sure what to use, look at past commits to the file(s) in your PR.
- Description, wrapped at ~72 characters
- Commits should be individually compilable, starting with the oldest commit. Make sure that each commit can be built if it and the preceding commits in the PR are used.
Information that needs to be part of a commit (if applicable):
- Ticket it fixes. E.g. "Fixes Bug #123."
- Compiler warnings addressed.
- Coverity Scan issues addressed.
- Static analyzer error it fixes (cppcheck/scan-build/etc)
When in doubt, check our git history for other messages or changes done to the same module your're working on. This is a good example of a commit message:
pcap/file: normalize file timestamps Normalize the timestamps that are too far in the past to epoch. Bug: #6240.
184.108.40.206.2. Pull Requests¶
A github pull request is actually just a pointer to a branch in your tree. GitHub provides a review interface that we use.
- A branch can only be used in for an individual PR.
- A branch should not be updated after the pull request
- A pull request always needs a good description (link to issue tracker if related to a ticket).
- Incremental pull requests need to link to the prior iteration
- Incremental pull requests need to describe changes since the last PR
- Link to the ticket(s) that are addressed to it.
- When fixing an issue, update the issue status to
In Reviewafter submitting the PR.
- Pull requests are automatically tested using github actions (https://github.com/OISF/suricata/blob/master/.github/workflows/builds.yml). Failing builds won't be considered and should be closed immediately.
- Pull requests that change, or add a feature should include a documentation update commit
220.127.116.11.3. Tests and QA¶
As much as possible, new functionality should be easy to QA.
suricata-verifytests for verification. See https://github.com/OISF/suricata-verify
- Add unittests if a
suricata-verifytest isn't possible.
- Provide pcaps that reproduce the problem. Try to trim as much as possible to the pcap includes the minimal set of packets that demonstrate the problem.
- Provide example rules if the code added new keywords or new options to existing keywords